@W-18902257 - [BOPIS] Implement feature toggle#2694
Merged
yunakim714 merged 19 commits intofeature/shop-in-storefrom Jun 30, 2025
Merged
@W-18902257 - [BOPIS] Implement feature toggle#2694yunakim714 merged 19 commits intofeature/shop-in-storefrom
yunakim714 merged 19 commits intofeature/shop-in-storefrom
Conversation
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
packages/template-retail-react-app/app/components/product-view/index.jsx
Outdated
Show resolved
Hide resolved
packages/template-retail-react-app/app/contexts/store-locator-provider.jsx
Outdated
Show resolved
Hide resolved
packages/template-retail-react-app/app/hooks/use-pickup-shipment.js
Outdated
Show resolved
Hide resolved
packages/template-retail-react-app/app/pages/checkout/confirmation.jsx
Outdated
Show resolved
Hide resolved
packages/template-retail-react-app/app/pages/checkout/util/checkout-context.js
Outdated
Show resolved
Hide resolved
packages/template-retail-react-app/app/pages/product-detail/index.jsx
Outdated
Show resolved
Hide resolved
patricksullivansf
approved these changes
Jun 30, 2025
alexvuong
reviewed
Jun 30, 2025
shauryemahajanSF
approved these changes
Jun 30, 2025
Contributor
shauryemahajanSF
left a comment
There was a problem hiding this comment.
Awesome! Tested these changes out, looks good to me.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Buy-Online-Pickup-In-Store (BOPIS) must be toggle-able, as there are customers who are online-only. We are using the
STORE_LOCATOR_IS_ENABLEDfeature toggle to enable/disable the BOPIS feature.Types of Changes
Changes
STORE_LOCATOR_IS_ENABLEDfromconstants.js- Iftrue, BOPIS is enabled. Iffalse, BOPIS is disabled and we should NOT see the Store Locator feature in the headerHow to Test-Drive This PR
STORE_LOCATOR_IS_ENABLEDtotrueSTORE_LOCATOR_IS_ENABLEDtofalseChecklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization