Skip to content

@W-18902257 - [BOPIS] Implement feature toggle#2694

Merged
yunakim714 merged 19 commits intofeature/shop-in-storefrom
W-18902257-bopis-feature-toggle
Jun 30, 2025
Merged

@W-18902257 - [BOPIS] Implement feature toggle#2694
yunakim714 merged 19 commits intofeature/shop-in-storefrom
W-18902257-bopis-feature-toggle

Conversation

@yunakim714
Copy link
Collaborator

@yunakim714 yunakim714 commented Jun 30, 2025

Description

Buy-Online-Pickup-In-Store (BOPIS) must be toggle-able, as there are customers who are online-only. We are using the STORE_LOCATOR_IS_ENABLED feature toggle to enable/disable the BOPIS feature.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • Read STORE_LOCATOR_IS_ENABLED from constants.js - If true, BOPIS is enabled. If false, BOPIS is disabled and we should NOT see the Store Locator feature in the header

How to Test-Drive This PR

  • Set STORE_LOCATOR_IS_ENABLED to true
    • Verify you can filter PLP by inventory
    • Verify you can select a Delivery option on the PDP
    • Verify you see the appropriate Cart header depending on the shipping method
    • Verify you can successfully go through the Checkout flow and place an order
  • Set STORE_LOCATOR_IS_ENABLED to false
    • Verify that you do not see the Store Locator modal, the PLP filter, and the PDP enhancements

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Jun 30, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@yunakim714 yunakim714 changed the base branch from develop to feature/shop-in-store June 30, 2025 15:51
@yunakim714 yunakim714 added the skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated label Jun 30, 2025
@yunakim714 yunakim714 marked this pull request as ready for review June 30, 2025 18:28
@yunakim714 yunakim714 requested a review from a team as a code owner June 30, 2025 18:28
Copy link
Contributor

@shauryemahajanSF shauryemahajanSF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Tested these changes out, looks good to me.

@yunakim714 yunakim714 merged commit 0d7be96 into feature/shop-in-store Jun 30, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants